Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prometheus generator url #1634

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Support prometheus generator url #1634

merged 11 commits into from
Nov 25, 2024

Conversation

moshemorad
Copy link
Contributor

No description provided.

moshemorad
moshemorad commented Nov 17, 2024
View reviewed changes
Copy link
Contributor Author

@moshemorad moshemorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking UI don't merge until version of frontend release.

@moshemorad moshemorad marked this pull request as draft November 17, 2024 12:03
@moshemorad moshemorad marked this pull request as ready for review November 24, 2024 11:23
arikalon1
arikalon1 previously approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Left 2 minor comments

src/robusta/core/reporting/url_helpers.py Outdated Show resolved Hide resolved
src/robusta/core/reporting/url_helpers.py Outdated Show resolved Hide resolved
@moshemorad moshemorad requested a review from arikalon1 November 24, 2024 16:08
arikalon1
arikalon1 previously approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a little tweak
left another comment

src/robusta/core/reporting/url_helpers.py Show resolved Hide resolved
@moshemorad moshemorad requested a review from arikalon1 November 25, 2024 07:49
arikalon1
arikalon1 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit dd2b6df into master Nov 25, 2024
5 checks passed
@arikalon1 arikalon1 deleted the add_prom_generator_url branch November 25, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

@RoiGlinik RoiGlinik Awaiting requested review from RoiGlinik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moshemorad @arikalon1