Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with OOM not being reported due to being captured downstream #1605

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: issue with OOM not being reported due to being captured downstream #1605

merged 1 commit into from
Oct 23, 2024

Conversation

nherment
Copy link
Contributor

@nherment nherment commented Oct 23, 2024 •
edited
Loading

The code in this PR is incorrect. The discovery process captures the error and simply restart. This means the __discover_resources function call should not rely on an exception being raised by Discovery.discover_resources() to check the oom flag

Front end payload example:

image

@nherment nherment marked this pull request as ready for review October 23, 2024 11:15
arikalon1
arikalon1 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit 95b7892 into master Oct 23, 2024
5 checks passed
@arikalon1 arikalon1 deleted the main-2282_improve_error_reporting_when_discovery_oom_fix branch October 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nherment @arikalon1