Created a new tab for notifications and routing #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantn
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Looks great. I have only one comment: The first page you see when clicking on "Notifications & Routing" seems a bit too "sudden". You land deep in the details of an advanced feature that is only supported for Slack, before you ever see the big picture or an overview.
Could we add a more general first page there? Maybe something titled "Notifications 101" or "Introduction to Notifications Routing". I think we can move this page and more or less re-use it for that. (Feel free to adjust the first paragraph and title a little to make it fit better as the index page, if appropriate.)
Sheeproid
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Created a new tab for notifications
Sheeproid
added a commit
that referenced
this pull request
Sep 25, 2024
* better explain the ui in config creation * Created a new tab for notifications and routing (#1558) * Created a new tab for notifications * update docs for openshift (#1560) * update docs for openshift * For openshift 4.15 to read prometheus metrics we need a binding to an existing prometheus cluster role --------- Co-authored-by: Arik Alon <alon.arik@gmail.com> * Add service and service monitor for forwarder (#1546) * Added holmes_conversation action * Updated comment for HolmesConversationIssueContext * Updated lightActions * Added HolmesToolsResult to verify tools input * Updated HolmesConversationRequest model * Added getting holmes model in ActivityStats * Made parameters optional for HolmesConversationIssueContext * Made some parameters for conversation api optional * Removed logging the error from get_holmes_model and fixed a bug * Added service and service monitor for forwarder * Updated values.yaml * Left only default values in forwarder.yaml * Add ability to set Assignee and Epic on Jira sink (#1564) * Add epic and assignee * Add epic and assignee * Add docs update * Fix formatting to align with other options * [MAIN-2105] switch related_pods from hikaru to k8s api (#1548) * switch related_pods from hikaru to k8s api * bugfix * remove log * bug fix * another bug fix * possible fix for perf issues w/ k8s library * add fix for logging via dockerfile * remove log * add patches, remove log * quick and dirty hack to workaround bug temporarily (this BREAKS THINGS and needs to be fixed before merge) * Fixed patching issues * changes before PR * patch unused * getting pods and limits * fixing get pod * reverted patches * pr fixes --------- Co-authored-by: avi robusta <avi@robusta.dev> * Updated kubewatch version to 2.9.0 (#1566) * MAIN-2112 Holmes using robusta ai (#1565) * add docs on how to use robusta ai with holmes * fixes --------- Co-authored-by: arik <alon.arik@gmail.com> * remove new from older integration and emphasized the HolmesGPT one (#1567) * Enable secrets for robusta (#1557) * Updated docs regarding secrets * Simplified syntax usage in docs for secret triggers * Updated playbook-track-secrets docs * Updated track secrets tutorial * Fixed secret triggers section * Fixed triggers markdown * Fixed import of render_generic_trigger * Removed custom description for secrets * Fix for _k8s-wildcard-triggers.jinja * Added custom description for Secrets * Updated Secret in kubernetes.rst * Changed secrets inline-ctx in kubernetes.rst * Checking if custom description works * Added escaping to secrets triggers * block scalar for inline-ctx * context instead of inline-context for secrets * _k8s-generic-triggers.jinja custom_description fix * Trying inline rst * Moved secret triggers to separate jijna file * Fixed usage of playbook-reference/triggers/_k8s-secrets-triggers.jinja * Removed sample image from playbook-track-secrets.rst * Fixed secret triggers display --------- Co-authored-by: arik <alon.arik@gmail.com> * changed "making" to signup --------- Co-authored-by: Pavan Gudiwada <25551553+pavangudiwada@users.noreply.github.com> Co-authored-by: Natan Yellin <aantn@users.noreply.github.com> Co-authored-by: Arik Alon <alon.arik@gmail.com> Co-authored-by: itisallgood <25401000+itisallgood@users.noreply.github.com> Co-authored-by: dabo <98835449+daanbosch@users.noreply.github.com> Co-authored-by: avi robusta <avi@robusta.dev> Co-authored-by: Roi Glinik <roi@robusta.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.