Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(json-webhook): Add json option to webhook sink #1185

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

shlomosfez
Copy link
Contributor

Option to send webhooks in JSON format for use it programatically.

In reference to: #1116

Recreated from #1184 because of issue with signing to the license

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shlomosfez
Looks great!

@arikalon1 arikalon1 merged commit 4de4601 into robusta-dev:master Nov 23, 2023
6 checks passed
@aantn
Copy link
Collaborator

aantn commented Nov 24, 2023

@shlomosfez would it be possible to open a new PR with an example demonstrating the JSON option?

To do so:

  1. You'll need to edit docs/configuration/sinks/webhook.rst
  2. You can run ./docs_autobuild.sh to preview the changes locally (optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants