Pod investigator enricher: move the reason-message part from enrinchments to description #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8855ceb to
795613f
Compare
arikalon1
reviewed
Nov 23, 2023
| if message is None: | ||
| message = "unknown" | ||
| event.add_enrichment([MarkdownBlock(f"\n\n{reason}: {message}")]) | ||
| # The code below is essentially a specialized version of ExcutionBaseEvent.override_finding_attributes |
There was a problem hiding this comment.
I would put this on the parent class, and a new method extend_description or add_to_description
def add_to_description(addition: str)
…ents to description
795613f to
7b71f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.