Added redirect to oss vs saas page #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavangudiwada
commented
Sep 21, 2023
- Fixes a FAQ URL on Robusta website
|
@pavangudiwada should it be If you've tested, please go ahead and merge. |
|
@aantn Fixed it. Previous local test worked because there isnt a /master path to replace and I manually tried it. The / was included at the end of localhost:8000/ so thought it would work. |
aantn
reviewed
Sep 24, 2023
docs/conf.py
Outdated
| @@ -60,6 +60,7 @@ | |||
| "user-guide/configuration.html": "/master/configuration/index.html", | |||
| "architecture.html": "/master/how-it-works/architecture.html", | |||
| "upgrade.html": "/master/setup-robusta/upgrade.html", | |||
| "oss-vs-saas.html": "master/how-it-works/oss-vs-saas.html", | |||
There was a problem hiding this comment.
@pavangudiwada does this need to start with / too?
aantn
approved these changes
Sep 24, 2023
pavangudiwada
added a commit
to pavangudiwada/robusta
that referenced
this pull request
Nov 6, 2023
* added redirect to oss vs saas page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.