Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic issue reply #1051

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Automatic issue reply #1051

merged 2 commits into from
Sep 7, 2023

Conversation

pavangudiwada
Copy link
Contributor

No description provided.

@pavangudiwada pavangudiwada requested a review from aantn August 24, 2023 06:37
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
I think we need to give less permissions

jobs:
build:
name: Welcome new contributor 🎉
permissions: write-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems way too permissive.
Why are you giving all those permissions to the job?
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

It's best to give minimal permissions.
Since our repo is public, anyone can reply to an issue.
Can we just give None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea you're right. We can change it to issues: write. We can't use None, because the GitHub action can't reply. This feature is for this GitHub action to automatically reply when a new contributor/user creates an issue.

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit 2d15c32 into master Sep 7, 2023
@arikalon1 arikalon1 deleted the feature/auto-issue-reply branch September 7, 2023 20:29
pavangudiwada added a commit to pavangudiwada/robusta that referenced this pull request Nov 6, 2023
* Automatic issue reply

* Updated job permission

---------

Co-authored-by: Pavan Gudiwada <pavangudiwada@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants