-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic issue reply #1051
Automatic issue reply #1051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I think we need to give less permissions
jobs: | ||
build: | ||
name: Welcome new contributor 🎉 | ||
permissions: write-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems way too permissive.
Why are you giving all those permissions to the job?
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
It's best to give minimal permissions.
Since our repo is public, anyone can reply to an issue.
Can we just give None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea you're right. We can change it to issues: write
. We can't use None, because the GitHub action can't reply. This feature is for this GitHub action to automatically reply when a new contributor/user creates an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Automatic issue reply * Updated job permission --------- Co-authored-by: Pavan Gudiwada <pavangudiwada@users.noreply.github.com>
No description provided.