happy-eyeballs: use the domain name of the first IP in connect_ip as identifier #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…identifier previously, "host.invalid" was used which does not contain any useful information
reynir
approved these changes
Nov 29, 2022
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 2, 2022
…s-lwt (0.4.0) CHANGES: * Cancellation of connection attempts (robur-coop/happy-eyeballs#30 @reynir @hannesm, fixes robur-coop/happy-eyeballs#27) * Make the type id abstract (suggested by @reynir in robur-coop/happy-eyeballs#30) * Add reason for failures to the variants, improves log output (robur-coop/happy-eyeballs#30, fixes robur-coop/happy-eyeballs#7, @hannesm @reynir) * Remove log messages about DNS resolution success/failure when there is no awaiting connection (robur-coop/happy-eyeballs#30, @hannesm) * Use the domain name of the fist IP address in connect_ip as identifier (this provides more useful information than the hardcoded "host.invalid") (robur-coop/happy-eyeballs#29, @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, "host.invalid" was used which does not contain any useful information
//cc @reynir