-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fakeFrameGrabber enhancements #2594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e1543b
to
7f28055
Compare
7f28055
to
c5ebf51
Compare
c5ebf51
to
f2b567b
Compare
Add "syncro" option to restore the old behavior
f2b567b
to
6f8041d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Devices
PR Type: Feat/Enh
This PR adds some new feature or enhances some part of YARP
Resolution: Merged
Target: YARP v3.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devices
fakeFrameGrabber
The
getImage()
method no longer blocks the caller.The
--syncro
option was added to restore the old behavior.The
topIsLow
option and theset_topIsLow
rpc command were added to produceimages with bottom to top scanlines.
The
nois
mode (introduced in fakeFrameGrabber_enh) was removed in favour ofthe
--noise
option andset_noise
andset_snr
commands that adds noiseto the generated images.
Depends on #2593 and #2583