Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes pre re-license #1551

Merged
merged 5 commits into from
Feb 18, 2018
Merged

Fixes pre re-license #1551

merged 5 commits into from
Feb 18, 2018

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Feb 16, 2018

Changelog will follow since a few changes might be reverted in the next few days.

@drdanz drdanz self-assigned this Feb 16, 2018
@drdanz
Copy link
Member Author

drdanz commented Feb 16, 2018

As announced in robotology/community#277, these changes break a few things and remove several features from YARP, therefore after the merge, you should not update your devel, unless you know what you are doing.

@drdanz drdanz force-pushed the fixes-pre-re-license branch 3 times, most recently from fa4a1ca to 6a55364 Compare February 17, 2018 23:54
@drdanz
Copy link
Member Author

drdanz commented Feb 18, 2018 •
edited
Loading

I just realized that the DISABLED property for tests is available only on CMake 3.9 or later.
It is working on macOS since it's using CMake 3.9.4, and on CLEAN_API builds since tests are disabled. I'll try setting the WILL_FAIL property instead.

@drdanz drdanz force-pushed the fixes-pre-re-license branch from 6a55364 to f3b7e53 Compare February 18, 2018 10:39
@drdanz drdanz force-pushed the fixes-pre-re-license branch from f3b7e53 to 3a4e482 Compare February 18, 2018 11:35
@drdanz
Copy link
Member Author

drdanz commented Feb 18, 2018

WILL_FAIL will still fail if the test segfaults! 😥
I fixed the TestFrameGrabber test, should be ok now...

Meanwhile I'm investigating the problem on windows...

@drdanz drdanz force-pushed the fixes-pre-re-license branch from 3a4e482 to d571db0 Compare February 18, 2018 11:55
@drdanz
dev: Prepare for re-licensing
16d8ad3 
* Move devices in the src/devices subfolder or in the plugins folder
* Remove yarp/dev/IKinectDeviceDriver.h and yarp/dev/IOpenNI2DeviceDriver.h
  includes
* The "serial" device is no longer a plugin.
* Several plugins are currently disabled.
* Tests for disabled plugins are disabled as well.

Fixes robotology#1543
Fixes robotology#1544
Fixes robotology#1545
Fixes robotology#1546
Fixes robotology#1547
Fixes robotology#1548
Fixes robotology#1549
@drdanz
extern: Import dirent 1.23.1 from https://github.com/tronkko/dirent
60e6630 
CC-Issue robotology#384
@drdanz
Use dirent from extern and remove copies of the file
ce83cb5 
CC-Issue robotology#384
@drdanz drdanz force-pushed the fixes-pre-re-license branch from d571db0 to ce83cb5 Compare February 18, 2018 13:32
@drdanz
Copy link
Member Author

drdanz commented Feb 18, 2018

Fixed windows issues (the destructor for IRangefinder2D was not in the dll, because the header was no longer included in any cpp file in the library), and (hopefully) the last few issues with YARP_math disabled and valgrind builds.

@drdanz drdanz merged commit 88d2f03 into robotology:devel Feb 18, 2018
@drdanz drdanz deleted the fixes-pre-re-license branch February 18, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@barbalberto barbalberto Awaiting requested review from barbalberto

@Nicogene Nicogene Awaiting requested review from Nicogene

@randaz81 randaz81 Awaiting requested review from randaz81

@vtikha vtikha Awaiting requested review from vtikha

Assignees

@drdanz drdanz

Labels
Component: Devices Component: GUI - yarpmanager Component: Library - YARP_dev Component: Library - YARP_os Component: Tool - yarpmanager-console PR Status: Changelog - Not Required This PR does not need a changelog entry Resolution: Merged Target: YARP v3.0.0 Type: Breaking/Behaviour Change Involves breaking user code or behaviour Type: Legal Involves legal stuff Type: Refactor Involves refactoring some part of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdanz @traversaro