Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devices][wholeBodyDynamics] replicate codyco-modules PR #280 Restore compatibility with YARP 3.2.0 #56

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

prashanthr05
Copy link
Contributor

Please see robotology-legacy/codyco-modules#280 Restore compatibility with YARP 3.2.0 for the original PR and related issue.

This PR adds changes to launch-wholebodydynamics-*.xml configuration files.

Changes to launch-wholebodydynamics-*.xml configuration files

Restore compatibility with YARP 3.2.0
@prashanthr05 prashanthr05 self-assigned this Apr 2, 2020
@prashanthr05 prashanthr05 changed the title [devices][wholeBodyDynamics] replicate codyco-modules PR #280 [devices][wholeBodyDynamics] replicate codyco-modules PR #280 Restore compatibility with YARP 3.2.0 Apr 2, 2020
@traversaro
Copy link
Member

I thought I just copied the files directly from codyco-modules, let's hope there are not more of this problems.

@prashanthr05
Copy link
Contributor Author

I thought I just copied the files directly from codyco-modules, let's hope there are not more of this problems.

#51 (comment)
I missed it in review as well.

Probably if we restore the add-wbd branch and look at the graph comparing it with the latest master of codyco-modules, we can understand if we missed something?

@prashanthr05
Copy link
Contributor Author

@traversaro I can proceed with the merge, right? These changes are working for me in simulation.

@traversaro
Copy link
Member

traversaro commented Apr 2, 2020

@traversaro I can proceed with the merge, right? These changes are working for me in simulation.

Yes, as you have to approval I guess it is ok to merge.

@prashanthr05 prashanthr05 merged commit 34c8186 into robotology:devel Apr 2, 2020
@prashanthr05 prashanthr05 deleted the fix/wbd_in_simulation branch April 2, 2020 09:24
@traversaro
Copy link
Member

Ah, I forgot two thins:

@prashanthr05
Copy link
Contributor Author

Ah, I forgot two thins:

Oops, I was wondering the same. I need to get used to this.

For now, I will add the changelog to devel and merge devel into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants