-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Workflow to check compilation in Windows, Ubuntu and MacOS (latest) #47
Add Github Workflow to check compilation in Windows, Ubuntu and MacOS (latest) #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -9,6 +9,12 @@ project(whole-body-estimators LANGUAGES CXX | |||
set(CMAKE_CXX_STANDARD 14) | |||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | |||
|
|||
## avoid having M_PI error by importing math symbols from standard cmath | |||
add_definitions(-D_USE_MATH_DEFINES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for me to understand, could you point me to a line where there's a potential math symbol error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you search for "error" in this raw log of that specific job in the workflow, you will find the problem. The raw log can be accessed by pressing ...
in this page https://github.com/prashanthr05/whole-body-estimators/runs/506436067?check_suite_focus=true
This was actually reported by @traversaro in #6 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking the raw log points to an expired url. It's better to go directly to the actions tab in the repository and check the status.
How did you do that? |
I've copied it & modified from another working repo 😄 . You can modify the link of the badge:
name: C++ CI Workflow
|
Then maybe we have to merge to devel and copy the badge of |
Yeah, we can do that. |
Sorry for the delay, interesting work I could not have really reviewed it since I do not now these workflow things yet. But looking at the code was useful to start getting acquainted. Nice @prashanthr05 explanations and comments are quite clear. |
Actually, it was only a very slightly modified version of the workflow in |
As a consequence of adding workflows,
Additionally,