Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Workflow to check compilation in Windows, Ubuntu and MacOS (latest) #47

Merged
merged 4 commits into from
Mar 16, 2020

Conversation

prashanthr05
Copy link
Contributor

As a consequence of adding workflows,

  • Updated dependencies
  • Windows compilation was fixed by minor modifications to CMakeLists.txt

Additionally,

  • Updated Authors

Copy link
Collaborator

@HosameldinMohamed HosameldinMohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's ok!, I also saw from your fork the test is passing.

Maybe we add a status badge in the README file.

Like this (I put the link of your fork):

System Continuous Integration Status
Linux/macOS/Windows GitHub Actions Status

@@ -9,6 +9,12 @@ project(whole-body-estimators LANGUAGES CXX
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

## avoid having M_PI error by importing math symbols from standard cmath
add_definitions(-D_USE_MATH_DEFINES)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for me to understand, could you point me to a line where there's a potential math symbol error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you search for "error" in this raw log of that specific job in the workflow, you will find the problem. The raw log can be accessed by pressing ... in this page https://github.com/prashanthr05/whole-body-estimators/runs/506436067?check_suite_focus=true

This was actually reported by @traversaro in #6 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking the raw log points to an expired url. It's better to go directly to the actions tab in the repository and check the status.

@prashanthr05
Copy link
Contributor Author

Maybe we add a status badge in the README file.

How did you do that?

@HosameldinMohamed
Copy link
Collaborator

HosameldinMohamed commented Mar 16, 2020

Maybe we add a status badge in the README file.

How did you do that?

I've copied it & modified from another working repo 😄 .

You can modify the link of the badge:

![GitHub Actions Status](https://github.com/prashanthr05/whole-body-estimators/workflows/C++%20CI%20Workflow/badge.svg) 
  • The link of the repository until the directory workflows is the location of the ci.yml file.
  • The phrase C++%20CI%20Workflow is the name in the top of the file ci.yml:
name: C++ CI Workflow
  • The badge.svg stays the same.

@prashanthr05
Copy link
Contributor Author

Then maybe we have to merge to devel and copy the badge of robotology remote rather than prashanthr05 fork?

@HosameldinMohamed
Copy link
Collaborator

Then maybe we have to merge to devel and copy the badge of robotology remote rather than prashanthr05 fork?

Yeah, we can do that.

@prashanthr05 prashanthr05 merged commit acec8db into robotology:devel Mar 16, 2020
@prashanthr05 prashanthr05 deleted the feature/add-workflows branch March 16, 2020 14:20
@fjandrad
Copy link
Contributor

Sorry for the delay, interesting work I could not have really reviewed it since I do not now these workflow things yet. But looking at the code was useful to start getting acquainted. Nice @prashanthr05 explanations and comments are quite clear.

@prashanthr05
Copy link
Contributor Author

Actually, it was only a very slightly modified version of the workflow in iDynTree and bipedal-locomotion-controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants