-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WBD launch files #173
Conversation
I'm not sure if we should maintain these files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Yes, I think we can remove them. Those were "special" as that robot only had legs. |
WBD runs with no errors, I haven't really checked what it's estimating! |
Also, the files |
The difference is inside the <elem name="left_leg_vsens">left_leg_virtual_strain</elem>
<elem name="right_leg_vsens">right_leg_virtual_strain</elem>
<elem name="torso_vsens">torso_virtual_strain</elem>
<elem name="right_arm_vsens">right_arm_virtual_strain</elem>
<elem name="left_arm_vsens">left_arm_virtual_strain</elem> Why is this happening? We need a bit of history here. The first versions of the iCubs used internally a set of CAN bus for communications with their internal control and sensor embedded boards. This had limitation of the amount of data that could be sent, so iCub 2.* was developed with an internal ETH (i.e. ethernet) bus that connected it with its internal control and sensor boards. This meant that However, the main difference for us is how joint torques estimates computed by WBD are sent down to the control boards for closing the torque loop. This measure is exposed to control boards via the In the case of CAN robots, there was a dedicated device called Instead, for ETH robots the What I just described applies to when the Sorry for the wall of text, if you got lost with all the names please let me know and we can discuss in person. |
Thanks a lot for the clear explanation. Got it now! |
This PR updates the launch files for
wholeBodyDynamics
to align them with the latestrobots-configuration
andicub-models
settings. The modifications include:I tested the launch file
launch-wholebodydynamics-icub-six-fts-sim.xml
withiCubGazebo2_5
, andlaunch-wholebodydynamics-icub3-sim.xml
withiCubGazeboV3
.For the others, that are supposed to be with real robots, I haven't tested them.
This may fix #169