Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation with iDynTree 3 #116

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Fix deprecation with iDynTree 3 #116

merged 5 commits into from
Jul 12, 2021

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jul 12, 2021 •
edited
Loading

In robotology/idyntree#770 the getSensorIndex variant that takes std::ptrdiff_t was deprecated, and it has been removed in the upcoming iDynTree 4 (robotology/idyntree#884). This PR fixes the deprecation warning in iDynTree 3 and the compilation with iDynTree 4.

I also bumped the version of iDynTree used in CI that it was quite old, and prevented the CI to compile correctly this PR.

@traversaro
Copy link
Member Author

I took the liberty of also bumping a release after this PR, as it would be good to have this out before iDynTree 4 gets released.

@traversaro traversaro mentioned this pull request Jul 12, 2021
Merged
HosameldinMohamed
HosameldinMohamed approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@HosameldinMohamed HosameldinMohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traversaro. Did you intend to merge it to master directly? unlike the past PRs?

@traversaro
Copy link
Member Author

Yes, being a bug fix I was thinking of merging in master and then forward merge to devel.

@traversaro
Copy link
Member Author

@prashanthr05 @HosameldinMohamed let me know if you prefer to handle the merge+release or if you prefer me to do it.

@HosameldinMohamed
Copy link
Collaborator

@prashanthr05 @HosameldinMohamed let me know if you prefer to handle the merge+release or if you prefer me to do it.

I can do it.

@HosameldinMohamed HosameldinMohamed merged commit 3643004 into master Jul 12, 2021
@HosameldinMohamed HosameldinMohamed deleted the fix_idyntree_deprecations branch July 12, 2021 10:41
@traversaro
Copy link
Member Author

Thanks @HosameldinMohamed ! Let me know if you need help then forward merging this to devel (the basic idea is similar to https://github.com/robotology/yarp/blob/master/.github/CONTRIBUTING.md#stable-branches-yarp-3x, but in the case of this repo the stable branch is master (in YARP is the yarp-3.x branch) and the development branch is devel (in YARP is master).

HosameldinMohamed pushed a commit that referenced this pull request Jul 12, 2021
@traversaro
Add Conda-based Continuous Integration (#117)
bb29f4f 
While working on #116, I noticed that the current CI is quite slow. In this PR I added a conda-based CI using the template already followed in other repos that should provide feedback on a PR much faster.
@HosameldinMohamed
Copy link
Collaborator

New release v0.5.1

@traversaro
Copy link
Member Author

New release v0.5.1

Thanks! I launched a new robotology-superbuild job to check if the compilation is indeed back to normal: https://github.com/robotology/robotology-superbuild/actions/runs/1022800284 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanthr05 prashanthr05 prashanthr05 approved these changes

@HosameldinMohamed HosameldinMohamed HosameldinMohamed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traversaro @HosameldinMohamed @prashanthr05