Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade robots to the latest NWS/NWC layers - 1 #321

Merged
merged 6 commits into from
Feb 1, 2022
Merged

Upgrade robots to the latest NWS/NWC layers - 1 #321

merged 6 commits into from
Feb 1, 2022

Conversation

davidetome
Copy link
Contributor

@davidetome davidetome commented Jan 3, 2022

This PR modifies XML files for the following robots :

  • iCubGenova04
  • iCubGenova02
  • iCubErzelli01
  • iCubErzelli02

The mods have been done starting from the default XML file contained in the yarprobotinterface.ini file (i.e. icub_all.xml)
The new files should be tested by the users.

@randaz81 , could you please have a look at them?

cc @pattacini @traversaro

@davidetome davidetome requested a review from randaz81 January 3, 2022 15:53
@davidetome davidetome self-assigned this Jan 3, 2022
@pattacini pattacini changed the title Upgrade robots to the latest NWS/NWC layers Upgrade robots to the latest NWS/NWC layers - 1 Jan 11, 2022
@davidetome
Copy link
Contributor Author

davidetome commented Jan 28, 2022

For this PR I tested on the robot the files for :

  • iCubGenova02
  • iCubGenova04

Also tested :

  • iCubErzelli01
  • iCubErzelli02

using DEBUG mode by adding these lines to the pc104.xml file :

    <group name="DEBUG">
        <param name="embBoardsConnected"> 0 </param>
    </group>

and setting in the general.xml file :

      <param name="skipCalibration">    true  </param>

This avoid yarprobotinterface terminating if not detects ETH boards; in this way, we test the correct parsing of the xml files.

cc @pattacini @Nicogene

@pattacini
Copy link
Member

Great @davidetome 👍🏻
Just awaiting the outcome of the tests on iCubErzelli0x and then I'll merge the PR.

@pattacini
Copy link
Member

Tested carried out successfully.
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants