Remove from testSkin/CMakeLists.txt installation of non existing dirs #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove testSkin experimental directory
|
This is necessary to fix the robotology-superbuild Travis (see https://travis-ci.org/robotology/robotology-superbuild/jobs/566430060). |
|
@traversaro testSkin can be removed from master; i use it for testing skin via socketcan in another branch |
|
@davidetome Ok, so I can update the PR to complete remove teskSkin, thanks! |
c9fbf8d to
4895671
Compare
|
@davidetome Done, if you want I can show you how to explicitly approve the PR by coming to production. |
|
Merging to fix robotology-superbuild given @davidetome approval in comments. |
|
@traversaro could you please merge |
Done in a6684d4, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #106 . Without his fix, the
INSTALL_ALL_ROBOTSoption fails during configuration.