Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cppad on Windows #544

Merged
merged 5 commits into from
Dec 3, 2020
Merged

Enable cppad on Windows #544

merged 5 commits into from
Dec 3, 2020

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Nov 28, 2020 •
edited
Loading

In particular, check if coin-or/CppAD#60 is fixed.

@traversaro traversaro mentioned this pull request Nov 28, 2020
Closed
@traversaro
Copy link
Member Author

There is a unrelated conda/macOS failure (it should be fixed by conda-forge/gazebo-feedstock#38) but other then that the fix seems to be working fine, if we update cppad to the latest version.

GiulioRomualdi
GiulioRomualdi reviewed Nov 28, 2020
View reviewed changes
CMakeLists.txt
Comment on lines -172 to -176
if(ROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPS)
find_or_build_package(manif)
find_or_build_package(qhull)
find_or_build_package(casadi)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part shouldn't be removed right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to describe this in the PR. As we are including these as dependencies of blf, there is no need to also duplicate these in the main CMakeLists.txt . I realized this when I had two modified in two places to enable cppad on Windows.

@GiulioRomualdi
Copy link
Member

On macOS s failing but since it does not depend on this PR I think you can merge it, right?

@traversaro
Copy link
Member Author

traversaro commented Nov 30, 2020 •
edited
Loading

On macOS s failing but since it does not depend on this PR I think you can merge it, right?

Yes, macOS/Conda failed but it was fixed by conda-forge/gazebo-feedstock#38, I just did not restarted the build.

@traversaro traversaro merged commit a2597de into master Dec 3, 2020
@traversaro traversaro deleted the fix-cppad-windows branch December 3, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioRomualdi GiulioRomualdi GiulioRomualdi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @GiulioRomualdi