Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDE profile to superbuild #231
Add HDE profile to superbuild #231
Changes from 13 commits
17ec3e8
b7fa3e9
41c7a5b
d247817
2685f86
d9de7e8
dbcf017
438afb6
f6a2a91
9672361
b2fe192
f1eae2d
0d1a88d
0dbd25d
7f2e75e
3d8f17a
fd5653d
b79e25d
2aa56fc
34e3b7e
96f3c36
e7ff49a
338dce5
6282d9e
544c834
cac76a3
9982607
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would invert the causality, I would document that the option
ROBOTOLOGY_USES_XSENS_MVN_SDK
option is only enabled when theROBOTOLOGY_ENABLE_HUMAN_DYNAMICS
CMake option is set to ON.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I wrote and what you said to me is equal! If you prefer, I can rephrase it as you mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed I see what you mean. As long as we have the
ROBOTOLOGY_USES_XSENS_MVN_SDK
I am ok with what you wrote.