Bump qhull and CppAD to latest versions #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
approved these changes
Feb 1, 2022
|
By the way, is this going to affect blf? There we require qhull v8 |
|
The 2020.2 tag was done later then the v8.0.* tags, so I think this should be ok: https://github.com/qhull/qhull/tags . |
|
Anyhow, blf is compiling fine in the CI, so I think we can merge. |
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work on branch https://github.com/traversaro/robotology-superbuild/tree/fix727 that was done to solve #727 . However, this part can be contributed on its own PR.
This PR bumps the qhull and CppAD version to track the latest version. In particular, this ensures that the versions used in the superbuild are compatible with the latest versions used in conda-forge:
Note that qhull has a bit of a complex versioning scheme, as it has releases like
8.0.2and2020.2. We switch to the2020.2-style tags for compatibility with most linux distros (see https://repology.org/project/qhull/versions) and with conda-forge.As this are external packages, they are fixed to releases in
LatestReleasesand also for Stable and Unstable branches.