Can battery

[triccyx]

Added to FW shared the Can battery board.

[pattacini]

Hi @triccyx

Remember that we need to handle the new version of the suite.

cc @marcoaccame

[triccyx]

Hi @triccyx

Remember that we need to handle the new version of the suite.

cc @marcoaccame

Uhm, what does this mean?

[pattacini]

Uhm, what does this mean?

It means this: https://github.com/robotology/icub-firmware-shared/pull/58/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a.

Get in touch with @marcoaccame about how to proceed here.

[triccyx]

@marcoaccame fixed:

• Names
• Size not Byte32 aligned
• Version

[marcoaccame]

Hi @triccyx:

• remember to increase VERSION in https://github.com/robotology/icub-firmware-shared/blob/devel/CMakeLists.txt#L9
• in eOas_battery_config_t::period the comment is misleading because it mentions strain2 and strain boards. You can just write something as: // if 0 -> DONT TX, else TX
• all the rest is fine.

[triccyx]

Ok done @marcoaccame

[triccyx]

@marcoaccame you should review as @pattacini does. It is easier to find the problems in this way. (I mean not using comments)

[marcoaccame]

Hi @triccyx: I forgot two small changes:

• advance protocol version of management endpoint to be 2.22 (see https://github.com/robotology/icub-firmware-shared/blob/devel/eth/embobj/plus/comm-v2/protocol/api/EoProtocolMN.h#L61)
• advance protocol version of analog sensor endpoint to be 1.7 (see https://github.com/robotology/icub-firmware-shared/blob/devel/eth/embobj/plus/comm-v2/protocol/api/EoProtocolAS.h#L60)

[triccyx]

@marcoaccame note that
advance protocol version of analog sensor endpoint to be 1.7 (see https://github.com/robotology/icub-firmware-shared/blob/devel/eth/embobj/plus/comm-v2/protocol/api/EoProtocolAS.h#L60)
is already 1.7. Is it all right?

[triccyx]

done

[marcoaccame]

@marcoaccame note that
advance protocol version of analog sensor endpoint to be 1.7 (see https://github.com/robotology/icub-firmware-shared/blob/devel/eth/embobj/plus/comm-v2/protocol/api/EoProtocolAS.h#L60)
is already 1.7. Is it all right?

Yes it is.

however, you still need to update protocol version of management

[triccyx]

done

[pattacini]

Can I merge the PR @marcoaccame?