Merge wearables repo in human-dynamics-estimation #395
Conversation
This PR add the wearable device implementation for an Adaptive Paexo
Add the optional parameter to save .mvn recording of xsens suit through SDK
Add AMTI wearable configuration file
Add brewInstallOrUpgrade function for MacOS CI
Add wearable yarp dumper application to run HDE offline
* Update CHANGELOG.md * Update CHANGELOG.md
* Add install for wearable devices dumper application * Update CHANGELOG.md * Update CMakeLists.txt
* Add github Actions CI, remove Travis CI * Remove iCub dependency * Set XSENS_MVN_USE_SDK=off in Windows CI * Update ci.yml * Update ci.yml * CI updated dependencies release * Update CHANGELOG * Remove Travis badge
Update wrappers CMakeLists to autogenerate .ini files
* update README.md with dependencies and compilation * Update README.md * Update CHANGELOG.md
Clean and update FTShoes configuration files
Cleanup plugin headers and IWear interface warning
Move wError and wWarning to common header
Stop using CHANGELOG.md
Fixed port name check if-statement logic
f47b170 to
177d7ba
Compare
|
@S-Dafarra @dariosortino given that you are the persons that recently merged PRs in hde, you won the co-mantainership of the new repo with me. : ) |
|
💔 |
|
What should we do after this PR? Uninstall wearables from the current superbuild installation, and update HDE? |
The only files that is better if they are removed are the one that are installed in |
|
I wonder whether it is cleaner if we move all the old wearables code in a single sub folder |
To be honest I did this like this as I wanted to do the least number of modifications post merge to get everything to build and install correctly, I wanted to leave further modifications cleanup after the merge. For sure for python integration it is useful to have both bindings in the same In the end the directories that mix hde and wearables are:
In all cases, the resulting |
|
I see! Actually, I got misled by the structure with which the file modifications are presented in the changes panel in Github. The structured seemed much more flat. By looking at the file structure in the branch directly, it makes more sense. Long story short, looks good to me. |
As described in robotology/wearables#212 .
The PR history is quite complicated as it contains all the history of wearables, but the relevant commits are actually 81f4c27 and 177d7ba, as they are the change to permit the merge.
Almost all the CMake options, CMake installed packages, and python packages should be exactly the same, permitting seamless migration from wearables+human-dynamics-estimation to the "merged" human-dynamics-estimation 4.0.0, the main exception are:
WEARABLES_COMPILE_PYTHON_BINDINGS,WEARABLES_DETECT_ACTIVE_PYTHON_SITEPACKAGES,WEARABLES_PYTHON_INSTALL_DIR,WEARABLES_PYTHON_PIP_METADATA_INSTALLandWEARABLES_PYTHON_PIP_METADATA_INSTALLERare not used, and insteadHDE_COMPILE_PYTHON_BINDINGS,HDE_DETECT_ACTIVE_PYTHON_SITEPACKAGES,HDE_PYTHON_INSTALL_DIR,HDE_PYTHON_PIP_METADATA_INSTALLandHDE_PYTHON_PIP_METADATA_INSTALLERare used also to enable/disable the installation of thewearablespython package.xmlyarpmanager files are installed in$CMAKE_INSTALL_PREFIX/share/HumanDynamicsEstimation, also the one that before were installed in$CMAKE_INSTALL_PREFIX/share/wearables, so that only$CMAKE_INSTALL_PREFIX/share/HumanDynamicsEstimationneeds to be added toYARP_DATA_DIRS.IWeartarget toIWear::IWearfor consistency with the namespace used during the install. If you have been usingwearablesviaFetchContent/add_subdirectory, please change all your instances ofWearable::IWeartoIWear::IWear.