Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gazebo_yarp_forcetorque] Expose fake temperature measurement #656

Merged
merged 7 commits into from
Jul 31, 2023
Merged

[gazebo_yarp_forcetorque] Expose fake temperature measurement #656

merged 7 commits into from
Jul 31, 2023

Conversation

HosameldinMohamed
Copy link
Contributor

Addresses #654

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HosameldinMohamed
Copy link
Contributor Author

HosameldinMohamed commented Jul 27, 2023 •
edited
Loading

The device fails when trying to use a multipleanalogsensorsserver wrapper.

I'm using a separate wrapper while disabling the implicit wrapper!

I'm not sure what's missing..

CC @traversaro

@HosameldinMohamed
Copy link
Contributor Author

The device fails when trying to use a multipleanalogsensorsserver wrapper.

I'm using a separate wrapper while disabling the implicit wrapper!

I'm not sure what's missing..

CC @traversaro

Now it's working as expected.
I forgot to implement one method of yarp::dev::ITemperatureSensors

@HosameldinMohamed HosameldinMohamed marked this pull request as ready for review July 28, 2023 09:57
traversaro
traversaro reviewed Jul 31, 2023
View reviewed changes
CHANGELOG.md
@@ -7,6 +7,10 @@ The format of this document is based on [Keep a Changelog](https://keepachangelo

## [4.7.0] - 2023-06-05

### Added

- The `gazebo_yarp_forcetorque` plugin now exposes also the `yarp::dev::ITemperatureSensors` interface, so it can stream fake temperature values (https://github.com/robotology/gazebo-yarp-plugins/pull/656).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this in the [Unreleased] section? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad!

Fixed in a56ab09

@traversaro
Copy link
Member

Just a minor comment.

@traversaro traversaro merged commit 691f610 into robotology:master Jul 31, 2023
@HosameldinMohamed HosameldinMohamed deleted the forceTorque_temperature branch July 31, 2023 14:03
@HosameldinMohamed HosameldinMohamed restored the forceTorque_temperature branch July 31, 2023 14:03
@HosameldinMohamed HosameldinMohamed deleted the forceTorque_temperature branch July 31, 2023 14:03
@HosameldinMohamed HosameldinMohamed restored the forceTorque_temperature branch July 31, 2023 14:03
@traversaro traversaro mentioned this pull request Jul 31, 2023
Closed
@Nicogene Nicogene mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HosameldinMohamed @CLAassistant @traversaro