Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll video inference job: use job_id if provided #317

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

PacificDou
Copy link
Contributor

Description

If user provides a job_id when call poll_for_video_results, we should use that id instead of self.job_id

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

YOUR_ANSWER

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PacificDou PacificDou marked this pull request as ready for review August 23, 2024 09:03
@PacificDou PacificDou merged commit eca5e97 into main Aug 23, 2024
8 checks passed
@PacificDou PacificDou deleted the bugfix-poll-video-job branch August 23, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants