Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes batches being created with None name #278

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fixes batches being created with None name #278

merged 1 commit into from
Jul 1, 2024

Conversation

joaomarcoscrs
Copy link
Contributor

@joaomarcoscrs joaomarcoscrs commented Jul 1, 2024 •
edited by iurisilvio
Loading

Description

Fix #263

  • Coalesces the value of batch_name used to build the image url to use the DEFAULT_BATCH_NAME when None.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Unit tests

@joaomarcoscrs joaomarcoscrs mentioned this pull request Jul 1, 2024
Closed
@joaomarcoscrs joaomarcoscrs self-assigned this Jul 1, 2024
@joaomarcoscrs joaomarcoscrs requested a review from iurisilvio July 1, 2024 19:00
iurisilvio
iurisilvio approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@iurisilvio iurisilvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@joaomarcoscrs joaomarcoscrs merged commit 1920a94 into roboflow:main Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurisilvio iurisilvio iurisilvio approved these changes

Assignees

@joaomarcoscrs joaomarcoscrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batches generated from python package are named None
2 participants
@joaomarcoscrs @iurisilvio