-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: CLI hangs with super big dataset #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHerrig
changed the title
Initial commit image/annotation dictoinaries
Initial commit image/annotation dictionaries
May 15, 2024
@tonylampada ready for review. |
tonylampada
changed the title
Initial commit image/annotation dictionaries
bugfix: CLI hangs with super big dataset
May 15, 2024
@NickHerrig this is looking great! |
tonylampada
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes roboflow-bugtracker#908
Two dictionaries were added to speed up the search for images and annotations rather than iterating through a list to find matches.
Along with that a tqdm loading bar was added to the image loop to give users feedback during the parsing of their annotation/image folder.
List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
All existing tests under
tests/util/test_folderparser.py
are passing after this work.An inital stub test below was implemented to test speed improvements on the CocoNut Datset.
if you have the coconut dataset, it can be passed to the dev container with the following docker-compose.yml
Before this PR:
After this PR: