Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: importing a yolo dataset with a trailing slash ignores annotations #248

Merged
merged 4 commits into from
Apr 26, 2024
Merged

BugFix: importing a yolo dataset with a trailing slash ignores annotations #248

merged 4 commits into from
Apr 26, 2024

Conversation

tonylampada
Copy link
Collaborator

@tonylampada tonylampada commented Apr 5, 2024 •
edited
Loading

Description

dumb bug:

roboflow import -w <workspaceId> -p <projectId> /path/to/some/yolo/format/dataset/
# uploads only images
roboflow import -w <workspaceId> -p <projectId> /path/to/some/yolo/format/dataset
# uploads images and annotations

This fixes it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

  • New test case
  • Tested uploading locally

@tonylampada tonylampada marked this pull request as draft April 5, 2024 19:51
@tonylampada tonylampada marked this pull request as ready for review April 26, 2024 15:12
@tonylampada tonylampada requested a review from probicheaux April 26, 2024 15:13
@tonylampada tonylampada changed the title Fix importing a yolo dataset with a trailing slash BugFix: importing a yolo dataset with a trailing slash ignores annotations Apr 26, 2024
@tonylampada tonylampada requested a review from capjamesg April 26, 2024 16:22
probicheaux
probicheaux approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@probicheaux probicheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@tonylampada tonylampada merged commit 244938d into main Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probicheaux probicheaux probicheaux approved these changes

@capjamesg capjamesg Awaiting requested review from capjamesg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonylampada @probicheaux