Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain the gh-pages branch history #25

Closed
wants to merge 1 commit into from

Conversation

robmoss
Copy link
Owner

@robmoss robmoss commented Sep 20, 2022

Pushing an innocuous commit (56682a0) appeared to reset the repository custom domain setting, making the book inaccessible. I don't know what caused this issue, but we previously deleted the existing gh-pages branch every time the book was updated. This commit makes the deploy action retain the branch history, and hopefully the custom domain will not be affected by future commits.

Pushing an innocuous commit (56682a0) appeared to reset the repository
custom domain setting, making the book inaccessible. I don't know what
caused this issue, but we previously deleted the existing gh-pages
branch every time the book was updated. This commit makes the deploy
action retain the branch history, and hopefully the custom domain will
not be affected by future commits.
@robmoss robmoss requested a review from EamonConway September 20, 2022 01:08
@robmoss
Copy link
Owner Author

robmoss commented Sep 20, 2022

I just pushed another commit to master (0ab7164) and once again the custom domain setting was reset.

@robmoss
Copy link
Owner Author

robmoss commented Sep 20, 2022

Some searching led me to this issue (also documented here) so apparently we need to create a CNAME file in the build directory.

@robmoss
Copy link
Owner Author

robmoss commented Sep 20, 2022

I've addressed this in commit 04cb2b0, which I pushed straight to master since that's the only way to test it, and it has resolved the DNS issue.

I still think we should retain the gh-pages branch history, as this would make it possible to publish online previews for pull requests (see #23).

@robmoss
Copy link
Owner Author

robmoss commented Sep 21, 2022

I've addressed this in #26 instead, which also adds online previews of each pull request.

@robmoss robmoss closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant