Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake vendor: use git to download taglib #142

Merged
merged 1 commit into from
Apr 12, 2024
Merged

rake vendor: use git to download taglib #142

merged 1 commit into from
Apr 12, 2024

Conversation

jacobvosmaer
Copy link
Collaborator

This will help with the switch to TagLib 2 because that version has a dependency in a Git submodule. By pulling in the submodule we don't have to install libutfcpp-dev with the system package manager anymore.

This will help with the switch to TagLib 2 because that version has a
dependency in a Git submodule.
@jacobvosmaer jacobvosmaer requested a review from robinst April 11, 2024 09:09
@jacobvosmaer
Copy link
Collaborator Author

This branch successfully runs TAGLIB_VERSION=2.0.1 rake vendor.

Copy link
Owner

@robinst robinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@jacobvosmaer jacobvosmaer merged commit de92ab5 into main Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants