Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements and set version in manifest of custom component #644

Conversation

peter-vanpoucke
Copy link

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Code quality improvements to existing code or addition of tests

Description

I wanted to install the component manually. The README proposes to install the requirements using pip, but that didn't seem to work for me using SSH. I was able to add the integration when I added the requirements to the manifest of the custom component. I've also set the version of the component.

@stickpin
Copy link
Collaborator

stickpin commented Jun 30, 2024

Hi @peter-vanpoucke,

Thanks for the PR, but it's not required. The version is added by the GitHub actions script during the release:
https://github.com/robinostlund/homeassistant-volkswagencarnet/blob/master/.github/workflows/release.yaml

Check manifest in the release.

Best Regards! :)

@stickpin stickpin closed this Jun 30, 2024
@peter-vanpoucke
Copy link
Author

Makes sense 😅. To install the repo, I cloned the repo and checked out the tag instead. Thanks for the info.

@peter-vanpoucke peter-vanpoucke deleted the dev/withUpdatedManifest/v5.0.2 branch June 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants