Fix bug in cancel_order due to wrong concatenation syntax (#296)

* Fix bug in cancel_order due to wrong concatenation syntax * Add news fragment
robinhood-unofficial · Nov 26, 2022 · 087580e · 087580e
1 parent 0448221
commit 087580e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/newsfragments/296.bugfix b/newsfragments/296.bugfix
@@ -0,0 +1 @@
+Fix bug in cancel_order due to wrong concatenation syntax.
diff --git a/pyrh/robinhood.py b/pyrh/robinhood.py
@@ -1444,7 +1444,7 @@ def cancel_order(self, order_id):  # noqa: C901
         """
         if isinstance(order_id, str):
             try:
-                order = self.get(urls.build_orders() + order_id)
+                order = self.get(urls.build_orders(order_id))
             except (requests.exceptions.HTTPError) as err_msg:
                 raise ValueError(
                     "Failed to get Order for ID: "
@@ -1475,7 +1475,7 @@ def cancel_order(self, order_id):  # noqa: C901
         elif isinstance(order_id, dict):
             order_id = order_id["id"]
             try:
-                order = self.get(urls.build_orders() + order_id)
+                order = self.get(urls.build_orders(order_id))
             except (requests.exceptions.HTTPError) as err_msg:
                 raise ValueError(
                     "Failed to get Order for ID: "

diff --git a/pyrh/urls.py b/pyrh/urls.py
@@ -113,7 +113,7 @@ def build_orders(order_id: Optional[str] = None) -> URL:
 
     """
     if order_id is not None:
-        return ORDERS_BASE / f"/{order_id}/"
+        return ORDERS_BASE / f"{order_id}/"
     else:
         return ORDERS_BASE
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug in cancel_order due to wrong concatenation syntax.