Add fatbin.ld linker script, compile with -fPIC, use -I instead of -isystem
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tax to avoid preprocessor errors in ccache
| ) | ||
|
|
||
| # Per-thread default stream option see https://docs.nvidia.com/cuda/cuda-runtime-api/stream-sync-behavior.html | ||
| # The per-thread default stream does not synchronize with other streams | ||
| target_compile_definitions(cugraph PUBLIC CUDA_API_PER_THREAD_DEFAULT_STREAM) | ||
|
|
||
| file(WRITE "${CUGRAPH_BINARY_DIR}/fatbin.ld" |
There was a problem hiding this comment.
In what situations are you hitting cugraph needing the fatbin trick? Was this the solution to the relocation truncated to fit: R_X86_64_REX_GOTPCRELX error you reported?
There was a problem hiding this comment.
I'm thinking that either this fixed it, or compiling with -fPIC did. Even if this wasn't the fix, we'll probably need it soon anyway because debug builds are starting to get big:
$ du -sh .cache/build/{Debug,Release}/{cudf,cugraph}-build/lib{cudf,cugraph}.so 2>/dev/null
3.2G .cache/build/Debug/cudf-build/libcudf.so
2.7G .cache/build/Debug/cugraph-build/libcugraph.so
142M .cache/build/Release/cudf-build/libcudf.so
149M .cache/build/Release/cugraph-build/libcugraph.so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.