Update show.1 #97
Closed
Update show.1 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor spelling corrections
roberthawdon
requested changes
May 8, 2019
|
Ok.. I've never heard of that tool, but will take a look.
d.
…________________________________
From: Robert Hawdon <notifications@github.com>
Sent: Wednesday, May 8, 2019 7:05 AM
To: roberthawdon/dfshow
Cc: deicherse; Author
Subject: Re: [roberthawdon/dfshow] Update show.1 (#97)
@roberthawdon requested changes on this pull request.
Could you update the ronn file and use Ronn to update the show.1 file please?
http://rtomayko.github.io/ronn/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#97 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHIICWKJFVYN22UC6JBOHEDPUKXY5ANCNFSM4HLJ3HKQ>.
|
|
You might find these docs interesting.
d.
…________________________________
From: Robert Hawdon <notifications@github.com>
Sent: Wednesday, May 8, 2019 7:05 AM
To: roberthawdon/dfshow
Cc: deicherse; Author
Subject: Re: [roberthawdon/dfshow] Update show.1 (#97)
@roberthawdon requested changes on this pull request.
Could you update the ronn file and use Ronn to update the show.1 file please?
http://rtomayko.github.io/ronn/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#97 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHIICWKJFVYN22UC6JBOHEDPUKXY5ANCNFSM4HLJ3HKQ>.
|
|
I was looking at the common code.
Regarding copying files without execute permissions quirkiness.
Is your general philosophy to:
1) Have logic to check source and destination before the attempt,
-and or-
2) To traps errors with try and catch?
Thanks,
Dan
…________________________________
From: Robert Hawdon <notifications@github.com>
Sent: Wednesday, May 8, 2019 7:05 AM
To: roberthawdon/dfshow
Cc: deicherse; Author
Subject: Re: [roberthawdon/dfshow] Update show.1 (#97)
@roberthawdon requested changes on this pull request.
Could you update the ronn file and use Ronn to update the show.1 file please?
http://rtomayko.github.io/ronn/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#97 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHIICWKJFVYN22UC6JBOHEDPUKXY5ANCNFSM4HLJ3HKQ>.
|
|
It's a bug, the desired result is for the copied file to have the same permissions as the original. I'll put a bug ticket in to get that fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor spelling corrections
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: