Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a directory show is currently in from command line will cause segfault #75

Closed
4 tasks done
roberthawdon opened this issue Feb 18, 2019 · 1 comment
Closed
4 tasks done

Deleting a directory show is currently in from command line will cause segfault #75

roberthawdon opened this issue Feb 18, 2019 · 1 comment
Assignees
@roberthawdon
Labels
bug Something isn't working

Comments

@roberthawdon
Copy link
Owner

roberthawdon commented Feb 18, 2019 •
edited
Loading

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

show should be able to handle the missing directory.

Current Behavior

Upon exiting from shell, show displays:

The location <<MISSING DIRECTORY>> cannot be opened or is not a directory

Then crashes

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. create a directory
  2. navigate to that directory in show
  3. Press ESC
  4. Press R
  5. cd out of the directory
  6. rm -r the directory
  7. type exit to return to show

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • DF-SHOW Version: 0.6.1
  • Operating System: Linux
  • System Architecture: x86_64
  • Output of uname -a: Linux ian-arch-XPS15-9560 4.20.10-arch1-1-ARCH #1 SMP PREEMPT Fri Feb 15 17:49:06 UTC 2019 x86_64 GNU/Linux

Failure Logs

Please include any relevant log snippets or files here.
@roberthawdon roberthawdon self-assigned this Feb 18, 2019
@roberthawdon roberthawdon added the bug Something isn't working label Feb 18, 2019
roberthawdon added a commit that referenced this issue Mar 2, 2019
@roberthawdon
Fixing seg fault when deleting a directory from "Run command"
923423a 
* Now `show` will return the user to the last valid directory in the
history.
* Addresses bug #75
@roberthawdon
Copy link
Owner Author

Fixed in develop branch

@roberthawdon roberthawdon mentioned this issue Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberthawdon roberthawdon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roberthawdon