Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating file and directory adds trailing slash to path #121

Closed
roberthawdon opened this issue Jan 30, 2020 · 1 comment
Closed

Creating file and directory adds trailing slash to path #121

roberthawdon opened this issue Jan 30, 2020 · 1 comment
Assignees
Labels
bug Something isn't working show Issue relates to Show application
Milestone

Comments

@roberthawdon
Copy link
Owner

Expected Behavior

File or Directory to be created and path to remain the same

Current Behavior

File or Directory is created, but a trailing slash is added to the path. This adds an extra step when navigating directories as the .. object will remove the trailing slash first.

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Enter a directory
  2. Use Touch File or Make Dir to create an object
  3. Observe pwd line add a trailing slash.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • DF-SHOW Version: 0.8.2-beta
  • Operating System: MacOS
  • System Architecture: x86_64
  • Output of uname -a: Darwin ***********.local 19.2.0 Darwin Kernel Version 19.2.0: Sat Nov 9 03:47:04 PST 2019; root:xnu-6153.61.1~20/RELEASE_X86_64 x86_64

Failure Logs

Please include any relevant log snippets or files here.

@roberthawdon roberthawdon added bug Something isn't working show Issue relates to Show application labels Jan 30, 2020
@roberthawdon roberthawdon added this to the v0.9.0 milestone Jan 30, 2020
@roberthawdon roberthawdon self-assigned this Jan 30, 2020
roberthawdon added a commit that referenced this issue Feb 1, 2020
@roberthawdon
Copy link
Owner Author

Fixed in the 0.9.0 branch

roberthawdon added a commit that referenced this issue Apr 4, 2020
roberthawdon added a commit that referenced this issue May 15, 2020
* Cut branch for 0.9

* Started adding acl/xaddr support

* Added definitions for acls

* (Not working) ACL work

* Initial working acl flag on MacOS

* Added xattr support for MacOS

* Swapped to ifdef

* Added ACL for Linux

* Added dummy -l flag for accidental `ls` muscle memory human (PEBKAC) related issues

* Testing SELinux checks

* Adding display test for SELinux acl

* Added flag for showing security context

* Adding context to struct

* Add Context Text to struct

* Actually copy the value to the variable

* Added libselinux

* Reworked automake linkers

* Handle -1 size

* Show stopping memory issues

* Fixed memory issue with attr field

* Starting work adding context to file output

* Added context header on -Z

* Added emacs files to ignore list

* Adding length of context and cleaning print entry

* Reverting printEntry change, adding contextlen

* Buffer overflow for perms

* Buffer overflow driver/size

* Buffer overflow driver/size - again

* Added context on -Z

* Fixed heading spacing for context

* Added missing padding on context larger than header

* starting work on segments

* Added segment pointers

* Added context segment

* Fixed padding on segments

* Made selinux optional

* Added extra memory for log10 calculations

* Context doesn't follow symlinks

* Switched attrs and hlink to segmemts

* Configured Travis to use SELinux as part of testing

* Sorting by name first before date and size

* This is to give the same results as ls if two files have the same
datestamp or size.

* Added handling if hard link count is less than 1

* Owner Segment implemented

* Date segment implemented

* Made marked a segment

* Fix hiding owner column

* Defined column names

* Add context to default conf file

* Fix issue where Driver header is shown when reading simlink to device.

Addresses #114 which happens when color mode is enabled.

* Added Mac theme

* New segment print system (buggy)

* Fix issue in new segment print system

* Updated mac theme

* Further fixes to new print segment routine

* Added default

* Fix driver/size display issue

* Removing entryMeta

* Preping for name segment

* Added Name Segment system

* Finishing name segment system

* Fix buffer overflow issue when displaying some directories

* Added TI theme inspired by NET-DFEDIT

* Started work on segmenting headers

* Completed working segmented headers

* Initalising header

* Updated copyright

* Allow reordering of segments

* Initialising memory in write segment routines

* Add one item per line option from ls

* Fixed segment size for name. Also cleaned up getseglength routine

* Made length of array dynamic

* Stopped --no-sf flag defaulting back to sf if no PAGER env is set

* Fixed header posiitoning if marked segment isn't shown

* Fixed size header justification

* Fixed header positioning when scrolling side ways

* Fixed over scrolling issue

* Making blank headers match data alignment

* Started working on skipping to first file

* Fixed skippable funtion to work on correct directory

* Added skip to first file option to config

* Fixed trailing slash issue.

Addresses issue #121

* Added skip to first file option argument

* Store xattrs in struct

* Freeing memory for xattrs

* Fixed memory issue with xattr storage

* Get size of xattr

* Corrected positioning of selected item

* Fixed issue where show segfaults if the directory it was launched in is
removed.

* Addresses issue #116

* Added skip-to-first option to default config file

* Further fixes to skip to first file

* Started work on the -@ flag

* More -@ work

* Further work on Xattr Mac support

* Fixed refresh issue, committing before possible refactor of display_dir

* Added entry line index struct

* Refactoring old functions

* Refactoring old functions further

* Fixed page down issue

* Displays xattrs

* XAttr segments and config settings

* Re-added support for GNU/HURD

* ACL work, reordered axFlag

* Disabling ACL view for now

* Set layout in config

* Fixed memory allocation issue with launch executable

* Made sys/xattr.h optional

* Removed xattr call when xattr not present

* Changed errorno output

* Added definitions for setting types

* Started work on moving files between devices

* Finished work moving files between devices

* Added find next on CTRL+F

Added feature for #119

* Fixed typo in help section

* Added initial autocomplete

For issue #108

* Completing autocomplete work for sf

Finishing #108

* Updated documentation

* Added SELinux support in documentation

* Reordered axFlag setting

* Fail config on missing acl library

* Reworked acl detection

* Further ACL work

* Fixed acl column not showing

* Fix incorrect disk space on some systems

Addresses #124

* Removing dev tag, prepairing for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working show Issue relates to Show application
Projects
None yet
Development

No branches or pull requests

1 participant