Switching to unsorted files can lead to a crash

[roberthawdon]

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

• I am running the latest version
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed
• I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

Selecting "unsorted" from the settings menu should show files in order they appear on the disk.

Current Behavior

Using the settings menu to change the sorting type to unsorted can cause a crash. Also, when -U is called from the command line, none of the options are highlighted in the settings menu.

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. launch show
2. press ESC and C to invoke the settings menu
3. change sorting method to unsorted
4. press Q to go back to the file list.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• DF-SHOW Version: 0.7.1 (also on 0.8.0-dev)
• Operating System: MacOS
• System Architecture: x86_64
• Output of uname -a: Darwin localhost.local 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64

Failure Logs

2019-06-18 09:30:44.233644+0100 show[12323:91361] detected buffer overflow
Process 12323 stoppedg order
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fff5fe4b2c6 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fff5fe4b2c6 <+10>: jae    0x7fff5fe4b2d0            ; <+20>
    0x7fff5fe4b2c8 <+12>: movq   %rax, %rdi
    0x7fff5fe4b2cb <+15>: jmp    0x7fff5fe45457            ; cerror_nocancel
    0x7fff5fe4b2d0 <+20>: retq
Target 0: (show) stopped.

[roberthawdon]

Issue no longer occurs on macOS after the above commit.