Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/coventry city council #1143

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix/coventry city council #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9e24fe
fix: updates coventry city council button text
jakeherp Jan 7, 2025
cc3d7e9
fix(tests): removes duplicate key for coventry city council
jakeherp Jan 7, 2025
dfdb67e
fix(tests): updates test case url for coventry city council
jakeherp Jan 7, 2025
a2b0a51
chore: updates file formatting
jakeherp Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions uk_bin_collection/tests/input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,12 +449,6 @@
"wiki_name": "Cornwall Council",
"wiki_note": "Use [FindMyAddress](https://www.findmyaddress.co.uk/search) to find your UPRN."
},
"CoventryCityCouncil": {
"url": "https://www.coventry.gov.uk/directory-record/56384/abberton-way-",
"wiki_command_url_override": "https://www.coventry.gov.uk/directory_record/XXXXXX/XXXXXX",
"wiki_name": "Coventry City Council",
"wiki_note": "Follow the instructions [here](https://www.coventry.gov.uk/bin-collection-calendar) until you get the page that shows the weekly collections for your address, then copy the URL and replace the URL in the command."
},
"CotswoldDistrictCouncil": {
"house_number": "19",
"postcode": "GL56 0GB",
Expand All @@ -465,7 +459,7 @@
"wiki_note": "Pass the full address in the house number and postcode in"
},
"CoventryCityCouncil": {
"url": "https://www.coventry.gov.uk/directory-record/56384/abberton-way-",
"url": "https://www.coventry.gov.uk/directory-record/62310/abberton-way-",
"wiki_command_url_override": "https://www.coventry.gov.uk/directory_record/XXXXXX/XXXXXX",
"wiki_name": "Coventry City Council",
"wiki_note": "Follow the instructions [here](https://www.coventry.gov.uk/bin-collection-calendar) until you get the page that shows the weekly collections for your address then copy the URL and replace the URL in the command."
Expand Down
2 changes: 1 addition & 1 deletion uk_bin_collection/uk_bin_collection/councils/CoventryCityCouncil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def parse_data(self, page: str, **kwargs) -> dict:
curr_date = datetime.today()

soup = BeautifulSoup(page.content, features="html.parser")
button = soup.find("a", text="Find out which bin will be collected when.")
button = soup.find("a", text="Find out which bin will be collected when and sign up for a free email reminder.")

if button["href"]:
URI = button["href"]
Expand Down
Loading