Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Added listener FlushLogContextListener for the logger context flushing #51

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

tarampampam
Copy link
Collaborator

@tarampampam tarampampam commented Jul 7, 2021

Description

Added

  • Listener FlushLogContextListener for the logger context flushing

Related PR: laravel/octane#337

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam self-assigned this Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #51 (e0602ad) into master (cd41168) will increase coverage by 0.07%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
+ Coverage     82.02%   82.10%   +0.07%     
- Complexity      257      260       +3     
============================================
  Files            54       55       +1     
  Lines           601      609       +8     
============================================
+ Hits            493      500       +7     
- Misses          108      109       +1     
Impacted Files Coverage Δ
src/Defaults.php 100.00% <ø> (ø)
src/Listeners/FlushLogContextListener.php 87.50% <87.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd41168...e0602ad. Read the comment docs.

@tarampampam
Copy link
Collaborator Author

Reminder: Unit tests are needed

@tarampampam tarampampam marked this pull request as ready for review July 8, 2021 05:22
@tarampampam tarampampam merged commit be4da38 into master Jul 8, 2021
@tarampampam tarampampam deleted the flush-log-context branch July 8, 2021 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant