Fix bunch of coverity issues.

[ni4]

Newly reported and one older one.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (9af62ce) to head (a5f3a8e).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2312   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files         118      118           
  Lines       22793    22793           
=======================================
+ Hits        19413    19414    +1     
+ Misses       3380     3379    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ni4]

@maxirmx do you have any idea why recently msys2 build environment started to use OSTYPE=cygwin, having the following debug output (you may find the full log in actions runs):

BASH=/usr/bin/bash
OSTYPE=cygwin
MSYSTEM=UCRT64
SHELL=/usr/bin/bash
-rwxr-xr-x 1 runneradmin None 2333443 Feb  4 17:02 /usr/bin/bash
	ntdll.dll => /c/Windows/SYSTEM32/ntdll.dll (0x7ff998700000)
	KERNEL32.DLL => /c/Windows/System32/KERNEL32.DLL (0x7ff997620000)
	KERNELBASE.dll => /c/Windows/System32/KERNELBASE.dll (0x7ff995df0000)
	USER32.dll => /c/Windows/System32/USER32.dll (0x7ff997f50000)
	msys-2.0.dll => /usr/bin/msys-2.0.dll (0x180040000)
	win32u.dll => /c/Windows/System32/win32u.dll (0x7ff996160000)
	GDI32.dll => /c/Windows/System32/GDI32.dll (0x7ff9981f0000)
	gdi32full.dll => /c/Windows/System32/gdi32full.dll (0x7ff995cd0000)
	msvcp_win.dll => /c/Windows/System32/msvcp_win.dll (0x7ff9963b0000)
	ucrtbase.dll => /c/Windows/System32/ucrtbase.dll (0x7ff996450000)
GNU bash, version 5.2.37(2)-release (x86_64-pc-cygwin)

I.e. bash is built with MSYS, MSYSTEM seems to be set properly, but Bash then tells that it is x86_64-pc-cygwin and sets OSTYPE to Cygwin?
While it could be fixes on ci-tests.sh level replacing switch value, wondering what's really changed as this worked before.

[maxirmx]

@maxirmx do you have any idea why recently msys2 build environment started to use OSTYPE=cygwin, having the following debug output (you may find the full log in actions runs):

BASH=/usr/bin/bash
OSTYPE=cygwin
MSYSTEM=UCRT64
SHELL=/usr/bin/bash
-rwxr-xr-x 1 runneradmin None 2333443 Feb  4 17:02 /usr/bin/bash
	ntdll.dll => /c/Windows/SYSTEM32/ntdll.dll (0x7ff998700000)
	KERNEL32.DLL => /c/Windows/System32/KERNEL32.DLL (0x7ff997620000)
	KERNELBASE.dll => /c/Windows/System32/KERNELBASE.dll (0x7ff995df0000)
	USER32.dll => /c/Windows/System32/USER32.dll (0x7ff997f50000)
	msys-2.0.dll => /usr/bin/msys-2.0.dll (0x180040000)
	win32u.dll => /c/Windows/System32/win32u.dll (0x7ff996160000)
	GDI32.dll => /c/Windows/System32/GDI32.dll (0x7ff9981f0000)
	gdi32full.dll => /c/Windows/System32/gdi32full.dll (0x7ff995cd0000)
	msvcp_win.dll => /c/Windows/System32/msvcp_win.dll (0x7ff9963b0000)
	ucrtbase.dll => /c/Windows/System32/ucrtbase.dll (0x7ff996450000)
GNU bash, version 5.2.37(2)-release (x86_64-pc-cygwin)

I.e. bash is built with MSYS, MSYSTEM seems to be set properly, but Bash then tells that it is x86_64-pc-cygwin and sets OSTYPE to Cygwin? While it could be fixes on ci-tests.sh level replacing switch value, wondering what's really changed as this worked before.

They just changed it 👎 It was a massive low to tebako pipelines as well and I did not find any word about it
I do not see any solution other then treat cygwin as msys

[ni4]

They just changed it 👎 It was a massive low to tebako pipelines as well and I did not find any word about it I do not see any solution other then treat cygwin as msys

Thanks for the prompt reply! Okay, let's go with the simpler solution.

[maxirmx]

LGTM

[ni4]

Merging with two approvals. Thanks all!