Update engine to precompile graphiql assets #76
Conversation
|
I can confirm this works on https://github.com/wesleyjellis/sprockets_graphql/tree/precompile |
|
Hello Robert @rmosolgo :) I can confirm that the provided fix indeed does the job and is also the expected way to go (at least according to the Rails Guides). Do you mind reviewing this and in case you agree with it, also merging and releasing it? I'm in the process of updating the How to GraphQL Ruby tutorial for Rails 6 and I'd like to avoid adding an instruction for the users to add the graphiql-assets in the manifest.js of their application. |
These instructions are needed as Sprockets 4 changes the logic for which assets are to be included for precompilation by default. They can be removed once rmosolgo/graphiql-rails#76 is merged and released.
These instructions are needed as Sprockets 4 changes the logic for which assets are to be included for precompilation by default. They can be removed once rmosolgo/graphiql-rails#76 is merged and released.
* update instructions for generating the LinkType
* bump graphiql-rails version to 1.7.0
* update explanation about fields resolution
* add instructions for adding GraphiQL assets to manifest.js
- These instructions are needed as Sprockets 4 changes the logic for
which assets are to be included for precompilation by default. They
can be removed once rmosolgo/graphiql-rails#76
is merged and released.
|
Hi @rmosolgo. Do you have plans to release a new version of this gem soon? It would be great if this PR could be merged into it. |
* update instructions for generating the LinkType
* bump graphiql-rails version to 1.7.0
* update explanation about fields resolution
* add instructions for adding GraphiQL assets to manifest.js
- These instructions are needed as Sprockets 4 changes the logic for
which assets are to be included for precompilation by default. They
can be removed once rmosolgo/graphiql-rails#76
is merged and released.
|
Sorry for the delay, and thanks for the fix! I'll cut a new release later today. |
Fix for #75
This is my first PR against an open-source project. I'm not sure if there's a better way to address this issue but this seems to work. Happy to get any feedback or iterate on this. I didn't see guidelines for contributing so please let me know if I can make this PR better!