Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iTerm theme #4

Merged
merged 1 commit into from
Nov 2, 2021
Merged

feat: add iTerm theme #4

merged 1 commit into from
Nov 2, 2021

Conversation

jose-elias-alvarez
Copy link
Contributor

Thanks for the great theme! It's been a while since I found something so pleasant and usable.

This PR adds a simple port of the Alacritty theme to iTerm.

@rmehri01
Copy link
Owner

rmehri01 commented Nov 2, 2021

Hey there, thanks for the pr and the kind words!

I think Alacritty is a bit of a special case since it seems to be a bit brighter than Kitty for example but let me know if it's different for you. I made the Kitty colors a bit brighter because of this so I would recommend following those.

One more thing is that I think the normal Nord theme for iTerm has some pretty nice defaults, so I would build off starting from that for some of the options like cursor guide and you can do so too if you'd like or I could give it a try!

@rmehri01
Copy link
Owner

rmehri01 commented Nov 2, 2021

I'll also tag @shMorganson since they seemed to have an iTerm theme too and might have some suggestions!

@jose-elias-alvarez
Copy link
Contributor Author

jose-elias-alvarez commented Nov 2, 2021

Got it. I tweaked it to use the original Nord theme as a base and the colors from the Kitty theme instead. On my screen, Kitty and iTerm now look identical in terms of colors (there's some minor rendering differences).

I don't really use the cursor guide, so I'm not sure what it's supposed to look like, but I left it alone for now.

Edit: The color used for selection_background in Kitty seemed like a good option for the cursor guide. Let me know how it looks!

@rmehri01
Copy link
Owner

rmehri01 commented Nov 2, 2021

This looks great, thanks again!

@rmehri01 rmehri01 merged commit 7d5a218 into rmehri01:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants