Make OneNord follow background option as it's set #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forced push fixes StyLua style violation. |
rmehri01
approved these changes
Jan 6, 2022
Before this change, the option was followed once
on initial load due to `require` behaviour.
Additionally, theme option is now respected
on repeated loads. E.g.:
```
:lua require('onenord').setup({theme = 'dark'})
:lua require('onenord').setup({theme = 'light'})
```
Yields a light variant, as you'd expect.
In order to unset forced theme, set it to `false`.
This is due to the fact that `{a = nil}` and `{}`
are equivalent. As such, providing `theme = nil`
is equivalent to not providing it at all.
|
Added I also removed |
|
I see, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the option was followed once
on initial load due to
requirebehaviour.Additionally, theme option is now respected
on repeated loads. E.g.:
Yields a light variant, as you'd expect.
In order to unset forced theme, set it to
false.This is due to the fact that
{a = nil}and{}are equivalent. As such, providing
theme = nilis equivalent to not providing it at all.