Add support for filetypes #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just plain globbing and trying to figure out file types by glob patterns, utilize existing ftdetect functionality of neovim. Fixes rmagatti#14 Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>
15a2346 to
11b2cac
Compare
rmagatti
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Hey, sorry about the delay. One issue I see here if I understand things correctly this looks at the filetype, and then based on what it finds for that, runs the glob pattern check. This poses two issues:
- This would be a breaking change
- This makes it mandatory to specify a filetype, but if I mean to operate on a given glob and not on a filetype necessarily, this PR would make that impossible.
I definitely like where this is going though. The biggest change I'd make here would be to not conflate filetypes with glob patterns, and just allow for specifying one and not the other as well as both if desired.
Thanks for the PR! I appreciate the contribution!
|
Moved on to gx.nvim, so I'll leave this for someone else to pick up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just plain globbing and trying to figure out file types by
glob patterns, utilize existing ftdetect functionality of neovim.
Fixes #14