Skip to content

Commit

Permalink
Do not stop the DevSession process before removing the Binding from t…
Browse files Browse the repository at this point in the history
…he Devfile

redhat-developer#6101 has been fixed.
  • Loading branch information
rm3l committed Jan 26, 2023
1 parent 322a4a3 commit e167c0c
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions tests/e2escenarios/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,18 +400,15 @@ var _ = Describe("E2E Test", func() {
stdout = helper.Cmd("odo", "list").ShouldPass().Out()
helper.MatchAllInOutput(stdout, []string{componentName, "Go", "Dev", bindingName})

// "exit dev mode"
devSession.Stop()
devSession.WaitEnd()

// remove bindings and check devfile to not contain binding info
// TODO: move `remove binding` inside devsession after https://github.com/redhat-developer/odo/issues/6101 is fixed
helper.Cmd("odo", "remove", "binding", "--name", bindingName).ShouldPass()

devSession, _, _, _, err = helper.StartDevMode(helper.DevSessionOpts{})
_, _, _, err = devSession.WaitSync()
Expect(err).To(BeNil())
stdout = helper.Cmd("odo", "describe", "binding").ShouldPass().Out()
Expect(stdout).To(ContainSubstring("No ServiceBinding used by the current component"))
Eventually(func() string { return helper.Cmd("odo", "describe", "binding").ShouldRun().Out() }).
WithTimeout(120 * time.Second).
WithPolling(5 * time.Second).
Should(ContainSubstring("No ServiceBinding used by the current component"))

devSession.Stop()
devSession.WaitEnd()
Expand Down

0 comments on commit e167c0c

Please sign in to comment.