Merge pull request #78 from josephg/master

Allow tarballs with @ in them
rlidwka · Jun 17, 2014 · 2052411 · 2052411
2 parents a79fa68 + 68bf469
commit 2052411
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -10,8 +10,7 @@ module.exports.validate_name = function(name) {
 	if (
 		name.charAt(0) === '.' || // ".bin", etc.
 		name.charAt(0) === '-' || // "-" is reserved by couchdb
-		name.match(/[\/@\s\+%:]/) ||
-		name !== encodeURIComponent(name) ||
+		name.match(/[\\\/\s\+%:]/) ||
 		name === 'node_modules' ||
 		name === '__proto__' ||
 		name === 'package.json' ||

diff --git a/test/unit/utils.js b/test/unit/utils.js
@@ -5,6 +5,7 @@ describe('Validate', function() {
 	it('good ones', function() {
 		assert(validate('sinopia'))
 		assert(validate('some.weird.package-zzz'))
+		assert(validate('old-package@0.1.2.tgz'))
 	})
 
 	it('uppercase', function() {
@@ -32,7 +33,6 @@ describe('Validate', function() {
 	})
 
 	it('other', function() {
-		assert(!validate('pkg@'))
 		assert(!validate('pk g'))
 		assert(!validate('pk\tg'))
 		assert(!validate('pk%20g'))