Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Route when Route errors with Insufficient_Fee #49

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

ziggie1984
Copy link
Contributor

No description provided.

@ziggie1984 ziggie1984 marked this pull request as ready for review December 29, 2022 19:34
@ziggie1984
Copy link
Contributor Author

I propose a feature request where we try the same route and hence the same channel pair if our rebalance attempt fails because of Insuffienct Fees.

We already do this for when the probing fails, so it would be good to add it when our first rebalance fails.

@ziggie1984
Copy link
Contributor Author

hmm I guess when we want to take account for a feeupdate we could expand also to the other failures like:

time_lock_delta, min_htlc_msat max_htlc_msat

@ziggie1984 ziggie1984 force-pushed the insufficient-fee branch 2 times, most recently from e0ea645 to b21ffc6 Compare January 1, 2023 07:13
@ziggie1984
Copy link
Contributor Author

This PR only considers changes in the cltv_delta and fee_update case.

@rkfg rkfg merged commit fe4caa2 into rkfg:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants