-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implements #297 request #4004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shubhcoder Thanks for doing this! Can you update the CHANGELOG.md
file as well with a description of this feature? I would expect to see sections for @rjsf/antd
, @rjsf/chakra-ui
, @rjsf/core
and a Dev / Docs / Playground
section.
value: number | undefined; | ||
}; | ||
|
||
export default function getDateElementProps( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add documentation to this function as well as replicating that documentation into the official RJSF online documentation found here packages/docs/docs/api-reference/utility-functions.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @heath-freenome
I have updated my PR with the required changes.
@Shubhcoder Your new tests seem to be failing. Is it because we are in a new year? Can you please investigate?
|
f845385
to
c18abc3
Compare
Reasons for making this change
I have added the code (with tests) to implement the feature requested in #297. Also, I have refactored the duplicate (non-React component) based function down into
@rjsf/utils
under the file namegetDateElementProps.ts
.Checklist
npm run test:update
to update snapshots, if needed.