-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass down indexed title from array field #4002
feat: pass down indexed title from array field #4002
Conversation
master merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the tests to validate these changes
CHANGELOG.md
Outdated
@@ -15,6 +15,12 @@ it according to semantic versioning. For example, if your PR adds a breaking cha | |||
should change the heading of the (upcoming) version to include a major version bump. | |||
|
|||
--> | |||
# 5.16.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a point release
# 5.16.1 | |
# 5.15.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Added tests for |
My only concern is that we're changing the displayed index from 0-based to 1-based. Should we consider that a breaking change? |
Very good point. Should I remove the The only reason I used 1 based indexing for title was that I think they are mostly used for cosmetic purposes and it is more readable. If the dev is not providing the title it means that they might not require the readiblilty part. |
Yes, having title be 1 based only is not a breaking change |
Reasons for making this change
Fixes #3983
Changes
ArrayField
to childrentitle
inSchemaField
,BooleanField
andObjectField
andArrayField
Checklist
npm run test:update
to update snapshots, if needed.