Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getFieldNames correctly defines array of primitives #3990

Conversation

Ariqun
Copy link
Contributor

@Ariqun Ariqun commented Dec 1, 2023

Reasons for making this change

I have custom multiple select that has value like string[]. If i use omitExtraData and liveOmit and chose value, rjsf clear select and rerender it. I have determined that this is due to getFieldNames skipping arrays with primitives ['value1'], causing such fields to be defined as empty.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome heath-freenome merged commit daa687a into rjsf-team:main Dec 5, 2023
4 checks passed
Rozamo pushed a commit to Rozamo/react-jsonschema-form that referenced this pull request Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants