Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build config, removing need for tslib dependency #3968

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Nov 20, 2023

Reasons for making this change

fixes #3958

Updating tsconfig files:

  • "importHelpers": false to remove need for tslib dependency
  • increase compilation target level from es6 to es2018 (so there are no need for transpiling object spread/rest feature, and so the helper for which tslib was needed)
  • add missing typescript project reference for snapshot-tests in a root tsconfig, also update it to use es modules like other packages

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@zxbodya zxbodya marked this pull request as ready for review November 20, 2023 10:20
@heath-freenome heath-freenome merged commit 4121305 into rjsf-team:main Nov 20, 2023
4 checks passed
@zxbodya zxbodya deleted the fix-tslib-dependency branch November 20, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages are using tsc-compiled files instead of ESM
2 participants