fix: Fixes #3805 by copying schema props rather than directly updating them #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
approved these changes
Aug 2, 2023
|
Ditto @epicfaace -- just a simple case where we pass a deeply frozen object would suffice IMO |
zxbodya
approved these changes
Aug 2, 2023
…y updating them Fixes rjsf-team#3805 by using object spread of schema changes rather than direct updating of schema properties - In `@rjsf/utils`, updated `resolveAllReferences()` to copy updated schema properties rather than directly changing them to avoid issues with frozen schemas - In `@rjsf/material-ui`, removed the unnecessary import of the `@types/material-ui` which was causing typescript issues in some situations
34438fc to
be13799
Compare
@nickgros @epicfaace I deep froze all of the test schemas ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #3805 by using object spread of schema changes rather than direct updating of schema properties
@rjsf/utils, updatedresolveAllReferences()to copy updated schema properties rather than directly changing them to avoid issues with frozen schemas@rjsf/material-ui, removed the unnecessary import of the@types/material-uiwhich was causing typescript issues in some situationsChecklist
npm run test:updateto update snapshots, if needed.